Merge Gaea modulefiles #1129
Merged
Merge Gaea modulefiles #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EricJames-NOAA Please open an new UPP issue and link it to this PR. Thanks! |
Closed
|
@gspetro-NOAA Could you do build testing on Gaea with this PR? There is no need to conduct the UPP RTs. |
gspetro-NOAA
approved these changes
Feb 4, 2025
WenMeng-NOAA
approved these changes
Feb 4, 2025
|
This PR is ready for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems unnecessary to have separate modulefiles for Gaea C5 and C6. It would greatly simplify building of rrfs-mpas-jedi branch of rrfs-workflow to have a unified UPP modulefile for Gaea.
UPP compiles on both C5 and C6 with this unified modulefile and updated detect_machine.sh.