Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bias and rmse time series diagnostic #107

Merged
merged 14 commits into from
Nov 17, 2021

Conversation

kevindougherty-noaa
Copy link
Collaborator

Closes #100. Script creates omf and oma time series that plots bias with and without bias correction and rmse. Currently only supports radiance data. Example plots here:

image
image

@CoryMartin-NOAA CoryMartin-NOAA added this to the FV3LAMDA Code Sprint milestone Nov 17, 2021
Copy link
Contributor

@JacobCarley-NOAA JacobCarley-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sample plots look great. I have one minor change request --> Recommend not using red and green together on the same plot for those with color vision deficiency. You could change the linestyle between with and w/o bc (e.g. solid to dashed or dotted). Some helpful info https://matplotlib.org/stable/tutorials/colors/colormaps.html

@kevindougherty-noaa
Copy link
Collaborator Author

Here is a new updated example addressing changes you recommended @JacobCarley-NOAA
image

Copy link
Contributor

@JacobCarley-NOAA JacobCarley-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line style and colors changed - awesome! Looks great.

@kevindougherty-noaa kevindougherty-noaa merged commit d8c1f5f into feature/LAMDA Nov 17, 2021
@kevindougherty-noaa kevindougherty-noaa deleted the feature/bias_rmse_timeseries branch November 17, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create timeseries of channel OmF RMSE/Bias
4 participants