modernize C-Fortran interface for crwbmg routines #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WRT doxygen I ran into this problem before and it's a weird one. Here's a stackoverflow question that gives the answer: So I updated the code to include that, and we'll see what the CI has to say... |
|
Wow, thanks Ed - I'm not sure I would have ever found that on my own! As you can see, the CI ran fine, and this also brings the gcovr up to exactly 80.0%, which is a good milestone!
The rendered Doxygen output also looks pretty-good too, so if you can approve this PR I'll go ahead and get it merged. And I'll go ahead and get #410 merged as well. |
edwardhartnett
approved these changes
Mar 24, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #79
Part of #252
Part of #254