Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded developer workflow to gcc-11/gfortran-11, also remove unneeded flag -fallow-invalid-boz #402

Merged
merged 7 commits into from
Mar 20, 2023

Conversation

edwardhartnett
Copy link
Contributor

@edwardhartnett edwardhartnett commented Mar 20, 2023

Part of #300
Fixes #403

@edwardhartnett
Copy link
Contributor Author

OK, funny thing is that switching to gcc-12/gfortran-12 causes gcovr to break. @GeorgeGayno-NOAA are you running your developer CI with gcc-12/gfortran-12? If so, that could explain the gcovr problem you've seen...

@edwardhartnett edwardhartnett changed the title turn on warning check in develop turn on -Wall in develop, also remove unneeded flag -fallow-invalid-boz Mar 20, 2023
@edwardhartnett edwardhartnett marked this pull request as ready for review March 20, 2023 14:13
@edwardhartnett edwardhartnett changed the title turn on -Wall in develop, also remove unneeded flag -fallow-invalid-boz upgraded developer workflow to gcc-11/gfortran-11, also remove unneeded flag -fallow-invalid-boz Mar 20, 2023
@GeorgeGayno-NOAA
Copy link

OK, funny thing is that switching to gcc-12/gfortran-12 causes gcovr to break. @GeorgeGayno-NOAA are you running your developer CI with gcc-12/gfortran-12? If so, that could explain the gcovr problem you've seen...

Looks like we are using mpifort/mpicc: https://github.com/ufs-community/UFS_UTILS/blob/develop/.github/workflows/developer.yml#L28

@jbathegit jbathegit merged commit 6c7bf5a into develop Mar 20, 2023
@edwardhartnett edwardhartnett deleted the ejh_warn branch March 20, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove -fallow-invalid-boz flag from build
3 participants