Feature/update to gfdl 20210224 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove "\n" from ALIASES as it tends to be passed through to latex and causes it to fail. - Add/move notes around in README.md and details/.
Doxygen support for 1.8.13 through 1.8.20
…ate-mom6-nov-2020
This patch trims some of the netCDF flag management and adds more explicit tests for the FMS and MOM6 flags. - We only test for -I flags when compiling the FMS library, since links are not required at compile-time. (NOTE: This may need verification for static builds on Gaea). - Further separation of C and Fortran flags. - libnetcdf support is explicitly added to MOM6. Previously it was not tested and linked. This is in preparation for FMS 2020.04 support.
+Add option to fix z-file layer initialization bug
The --cflags/--fflags arguments of nc-config/nf-config can be volatile, since they generally represent library install-time flags, so we instead replace them with --includedir/--libdir flags, which explicitly denote the installation paths. The only real issue here is that nf-config does not have a --libdir flag, so we use $(nf-config --prefix)/lib and hope that this is where it's installed.
The verification tests in .testing are updated to run on FMS 2020.04. Also, several documentation outputs in .gitignore were moved to docs/.gitignore, as well as some older files and directories that were interfering with content in ac/deps.
Eliminate unneeded variables in diabatic_driver
Update CPT fork of MOM6 to latest (12/10/2020) from NOAA-GFDL
Autoconf netCDF flag update
Doxygen was not assigning some docstrings for multiline variable declarations, so this patch splits those variables to one per line, with updated docstrings. Whitespace was also condensed in several of the declarations.
Reduction in line length of any lines exceeding 120 characters.
Added the overloaded interface rescale_comp_data to MOM_domains_infra to rescale the values in the computational domain of a 2-d, 3-d, or 4-d array by some factor without having to know the index convention that those arrays used. Also simplified some of the code in MOM_io_infra by making use of rescale_comp_data, and added a new optional scale argument to the various MOM_write_field routines. All answers are bitwise identical, but there are new interfaces and optional arguments for existing routines.
Use the new scale argument to MOM_write_field to simplify write_vertgrid_file and write_ocean_geometry_file. All output and answers are bitwise identical.
Added and used the file_type as the handle for input and output, changing from using an integer. This changes the type of one of the required arguments to write_field, write_MOM_field, create_file, reopen_file, get_file_info, get_file_times, get_file_fields, write_metadata_axis and write_metadata_field, and added new variants of open_file, close_file and flush_file using this new type. Also added the new routine file_is_open. All answers are bitwise identical, but there are changes to multiple I/O interfaces.
Added the new optional scale argument to the real versions of the read_variable routines. All answers are bitwise identical, but there are new optional arguments to public routines.
Revised the depth list type used in MOM_sum_output to accommodate I/O using ordinary routines, and to make the code creating, reading and writing it potentially separable from the MOM_sum_output module by avoiding the use of the MOM_sum_output control structure in most of the routines. Also changed the index 'l' to 'li' in some places to avoid having it misread as '1'. All answers are bitwise identical but there are changes in some subroutine arguments.
Fixing an indexing error in MOM_barotropic
trailer.py PEP8/PEP257 cleanup
MOM6: +I/O interface changes, including a new file_type
- this addresses a bug in the apply_ALE_sponge routine which had been passing zero values to the remapping routine for the target grid thicknesses.
…_022321 Ale sponge fix 022321
…ate-2021-02-19 Dev gfdl main candidate 2021-02-19
…update-to-GFDL-20210224 this is corresponding to GFDL 20210224 main branch commit (hash # 00c2819)
|
upload hera run log |
|
upload orion run log |
|
upload dell-p3 log |
|
@jiandewang We need to have these logs posted to the ufs-weather-model repo when it comes time for you to make the commit to ufs-weather and mom6 (at the same time). The need to be committed as .log files to the repo. So once you begin your commit to ufs-weather and post all the logs to ufs-weather, then we can approve the PR to the MOM6 repo; you'll then make a change in your ufs-weather branch to point to the new MOM6 develop. The ufs-weather PR will then get merged. But all the testing needs to show in the ufs-weather PR. |
|
@DeniseWorthen: understood, thanks. |
JessicaMeixner-NOAA
approved these changes
Mar 4, 2021
|
all RT in ufs-weather-model are done. |
jiandewang
pushed a commit
to jiandewang/MOM6
that referenced
this pull request
Jun 17, 2021
Merge in latest dev/gfdl updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issues Fixed (include github issue #):
MOM6 Issue update MOM6 20210224 #55
ufs-weather-model Issue 438 (update MOM6 to GFDL's 20210224 commit ufs-community/ufs-weather-model#438)
Are changes expected to change answers?
Testing performed:
Hashes used for testing
NEMS: b80b5b18
CMEPS: 0658dde
FV3: 70e55f21
CICE: f773ef38
FV3: 70e55f21
WW3: a89e2a6
stochastic_physics: c39bb8a
MOM6: a729a7f (https://github.com/jiandewang/MOM6/tree/feature/update-to-GFDL-20210224)