Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hera gnu spack-stack path and modulefile typo #67

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

RussTreadon-NOAA
Copy link
Contributor

This PR enables the gnu build of GSI-utils on Hera by

  • updating the spack-stack/1.6.0 MODULEPATH
  • replacing intel variables with gnu variables

in modulefiles/gsiutils_hera.gnu.lua

Resolves #66

Copy link
Collaborator

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thanks @RussTreadon-NOAA!

@DavidHuber-NOAA DavidHuber-NOAA requested review from aerorahul and CoryMartin-NOAA and removed request for aerorahul January 31, 2025 17:05
@DavidHuber-NOAA
Copy link
Collaborator

@CoryMartin-NOAA Could you please review this PR? Since I am not a code owner, my review does not satisfy the review requirement.

@RussTreadon-NOAA
Copy link
Contributor Author

Thank you @CoryMartin-NOAA

@RussTreadon-NOAA RussTreadon-NOAA merged commit d2e7034 into develop Jan 31, 2025
8 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the bugfix/hera_gnu branch January 31, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hera gnu build is broken
3 participants