Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GFS.v16: update model/nh_utils.F90 with dz_min change #41

Merged

Conversation

junwang-noaa
Copy link
Collaborator

To resolve the model instability issue:
-The dz_min is changed from 2 to 6, and the order of computation is updated to run the code efficiently.

@junwang-noaa junwang-noaa changed the title update model/nh_utils.F90 with dz_min change GFS.v16: update model/nh_utils.F90 with dz_min change Oct 2, 2020
Copy link
Collaborator

@yangfanglin yangfanglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@junwang-noaa junwang-noaa merged commit 08429c2 into NOAA-EMC:production/GFS.v16 Oct 2, 2020
@climbfuji
Copy link

@junwang-noaa are you planning to bring this back to dev/emc ? Are there any notes or an issue describing the problem? It sounds like it could be relevant for the GSL physics team, but I can't tell from the code changes alone. Thanks!

@yangfanglin
Copy link
Collaborator

yangfanglin commented Oct 2, 2020 via email

@junwang-noaa
Copy link
Collaborator Author

junwang-noaa commented Oct 2, 2020 via email

@climbfuji
Copy link

Thanks, @yangfanglin and @junwang-noaa. This is useful to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants