Skip to content

Commit

Permalink
Better filtering of D and revert obs QC (#1226)
Browse files Browse the repository at this point in the history
This PR adds a bit more flexibility to the filtering of D, making use of
the generic diffusion and allowing for much larger scales that the
simple filtering that we used before.
I also reverted the sst obs error to something a bit more realistic.

- fixes #1219
- fixes #1217 
- fixes #1232 

**This work will now require a companion PR in the `global-workflow`**

---------

Co-authored-by: JohnSteffen-NOAA <77806417+JohnSteffen-NOAA@users.noreply.github.com>
  • Loading branch information
guillaumevernieres and JohnSteffen-NOAA authored Jul 30, 2024
1 parent 7e09cdc commit f62b912
Show file tree
Hide file tree
Showing 33 changed files with 571 additions and 385 deletions.
31 changes: 4 additions & 27 deletions parm/soca/berror/soca_diagb.yaml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -26,35 +26,12 @@ max ssh: 0.0 # Limits the amplitude of the unbalanced bkg err
min depth: 500.0 # zero out the bkg. error. at less than min depth
number of halo points: 4
number of neighbors: 16

simple smoothing:
horizontal iterations: 10
vertical iterations: 1

# TODO(G): Start using when the normalization is optional
# TODO(G): Too slow for the below scale
#diffusion:
# saber block name: EXPLICIT_DIFFUSION
# active variables: [tocn, socn, ssh, cicen, hicen, hsnon]
# geometry:
# mom6_input_nml: mom_input.nml
# fields metadata: ./fields_metadata.yaml
# group mapping:
# - name: ocean
# variables:
# - tocn
# - socn
# - ssh
# - name: ice
# variables:
# - cicen
# - hicen
# - hsnon
# read:
# groups:
# - name: ocean
# horizontal:
# filename: hz_ocean.nc
# vertical:
# filename: vt_ocean.nc
# - name: ice
# horizontal:
# filename: hz_ice.nc
# horizontal: 500.0e3
# vertical: 3.0
6 changes: 3 additions & 3 deletions parm/soca/fields_metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,21 +75,21 @@
- name: hicen
getval name: sea_ice_category_thickness
io file: ice
io name: hicen
io name: hi_h
property: positive_definite
fill value: 0.0

- name: cicen
getval name: sea_ice_category_area_fraction
getval name surface: sea_ice_area_fraction # note: not accurate, should be "sum" not "surface"
io file: ice
io name: aicen
io name: aice_h
fill value: 0.0

- name: hsnon
getval name: sea_ice_category_snow_thickness
io file: ice
io name: hsnon
io name: hs_h
property: positive_definite
fill value: 0.0

Expand Down
Loading

0 comments on commit f62b912

Please sign in to comment.