Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify files in sat_vapor_pres directory #4

Merged
merged 8 commits into from
Oct 18, 2021
Merged

Modify files in sat_vapor_pres directory #4

merged 8 commits into from
Oct 18, 2021

Conversation

MinsukJi-NOAA
Copy link
Collaborator

@MinsukJi-NOAA MinsukJi-NOAA commented Oct 10, 2021 •
edited
Loading

Description
Modify subroutines in sat_vapor_pres.F90 and sat_vapor_pres_k.F90 files.

How Has This Been Tested?
Unit tests in CI all passed. HOWEVER, there are no unit tests for sat_vapor_pres

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@MinsukJi-NOAA MinsukJi-NOAA merged commit 64a4504 into NOAA-EMC:fms_mixedmode Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MinsukJi-NOAA