Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake package #8

Merged
merged 3 commits into from
Jun 15, 2020
Merged

cmake package #8

merged 3 commits into from
Jun 15, 2020

Conversation

aerorahul
Copy link
Contributor

Keeping up with the packaging work of @kgerheiser, this PR adds that capability to CRTM.
Since there is no develop branch, this PR is merging into release/public-v1
There are no changes necessary downstream.

Change-Id: Ifb0beb698119f5f57bea93128abf6ea5c07d5fd4
Change-Id: I7b3e13c1c1f6398b10738c09af0de600dc72bada
@DusanJovic-NOAA
Copy link

Let's create develop branch to make this repository consistent with other NCEPLIBS-* and make it easy to write install scripts that loop over all libraries.

@aerorahul
Copy link
Contributor Author

Let's create develop branch to make this repository consistent with other NCEPLIBS-* and make it easy to write install scripts that loop over all libraries.

I have no issues with creating a develop branch so long as it is understood that this project is not under development. I would sooner rather than later move over to the authoritative CRTM repository and decommission this.

@DusanJovic-NOAA
Copy link

I see this repository is not a GitHub fork of another repository. Where is CRTM's authoritative repository and who maintains it?

@aerorahul
Copy link
Contributor Author

I see this repository is not a GitHub fork of another repository. Where is CRTM's authoritative repository and who maintains it?

This is the CRTM's authoritative repository here
JCSDA maintains a releases from there.

@DusanJovic-NOAA
Copy link

I get "Page not found" error when I click here. Is this public repository?

@DusanJovic-NOAA
Copy link

I compiled successfully this branch on WCOSS Dell and linked ufs-weather-model using crtm::crtm imported target.

@aerorahul
Copy link
Contributor Author

I get "Page not found" error when I click here. Is this public repository?

It is under the JCSDA organization. Nevertheless, the repository looks nothing like this one. It is hopeless to expect a cleaned up repository that we can simply fork and use for our purpose in any reasonable amount of time. I say, park this issue and move ahead. Please review and give a 👍 / 👎 .

@aerorahul aerorahul merged commit dfbbcca into NOAA-EMC:release/public-v1 Jun 15, 2020
@aerorahul aerorahul deleted the feature/cmake-pkg branch June 15, 2020 19:35
@DusanJovic-NOAA
Copy link

How about creating develop branch?

@aerorahul
Copy link
Contributor Author

How about creating develop branch?

done.

@BenjaminTJohnson
Copy link

Public repositories on the JCSDA github are coming "soon". Seems that I cannot push for this hard enough to make it happen, but it definitely has to happen around Oct 23: JEDI public release, CRTM v2.4.0 public release. I already have a REL_2.3.0_emc build release (not the development structure that we use internally).

Of course, anyone who is interested can have access to the private repository to have a look, just send me your github username.

As soon as there's an update on the public availability, I will let you all know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants