modify cmeps for correct signs from ATM #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove custom merge related solely to need to change sign
* tested in develop branch for all HAFS tests and all passed
This was referenced Jun 30, 2023
|
I saw "hafs" mode is changed in med_phases_prep_atm_mod.F90, so the changes will impact HAFS? |
|
No, that change just removes an un-used feature. The hafs mode does not use the aoflux calculation. The only changes are to any test are the mediator restart files, because the fields have a swapped sign. I actually plan to retest once more after today's CICE PR, just to verify nothing else changes. |
junwang-noaa
approved these changes
Aug 2, 2023
BrianCurtis-NOAA
approved these changes
Aug 7, 2023
|
Ok, @DeniseWorthen . I think we're ready to begin the merge process. Feel free to merge this sub-component PR when you're able. As discussed on this morning's CM call, HYCOM has already been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Removes custom merges required because ATM does not send correct sign or unit.
fixes CMEPS is forced to use custom merges because sign of field imported from ATM is wrong or unit conversion is required #93
required by Make signs of fields exported by ATM consistent with positive-down for CMEPS ufs-community/ufs-weather-model#1807