Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing felim for Diazo? #27

Closed
yichengt900 opened this issue Apr 2, 2024 · 0 comments
Closed

Missing felim for Diazo? #27

yichengt900 opened this issue Apr 2, 2024 · 0 comments
Assignees
@charliestock @yichengt900
Labels
CodeCleanUp

Comments

@yichengt900
Copy link
Collaborator

yichengt900 commented Apr 2, 2024 •
edited
Loading

As titled:

ocean_BGC/generic_tracers/generic_COBALT.F90

Line 8279 in 6e6ed11

min(phyto(n)%po4lim(i,j,k), phyto(n)%def_fe(i,j,k))

should this be consistent with the other phyto types:

ocean_BGC/generic_tracers/generic_COBALT.F90

Line 8282 in 6e6ed11

phyto(n)%po4lim(i,j,k), max(phyto(n)%def_fe(i,j,k),phyto(n)%felim(i,j,k)))

PR #31 addresses this issue
charliestock pushed a commit that referenced this issue Apr 4, 2024
added felim to diazo iron limitation to address issue #27
833db6a
yichengt900 pushed a commit that referenced this issue Apr 4, 2024
@charliestock
added felim to diazo iron limitation to address issue #27 (#31)
d4e20e4 
Co-authored-by: Charles Stock <Charles.Stock@an002.princeton.rdhpcs.noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliestock charliestock

@yichengt900 yichengt900

Labels
CodeCleanUp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@charliestock @yichengt900