Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for ${ProcessDir} in internalLogFile when parsing nlog.config #3862

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Support for ${ProcessDir} in internalLogFile when parsing nlog.config #3862

merged 1 commit into from
Apr 1, 2020

Conversation

snakefoot
Copy link
Contributor

Improve support for single file publish where Process-Executable-Directory ${processdir} is the valid location (Not ${basedir})

@snakefoot snakefoot force-pushed the InternalLoggerProcessDir branch from 0a779c1 to 3f53cb1 Compare March 25, 2020 23:53
@304NotModified 304NotModified added this to the 4.7.1 milestone Mar 26, 2020
@snakefoot snakefoot added the enhancement Improvement on existing feature label Mar 27, 2020
@304NotModified 304NotModified changed the title Support ProcessDir variable for internalLogFile when parsing nlog.config Support for ${ProcessDir} in internalLogFile when parsing nlog.config Mar 28, 2020
304NotModified
304NotModified approved these changes Mar 28, 2020
View reviewed changes
Copy link
Member

@304NotModified 304NotModified left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snakefoot snakefoot force-pushed the InternalLoggerProcessDir branch from 3f53cb1 to 1b34110 Compare March 31, 2020 21:20
@snakefoot snakefoot force-pushed the InternalLoggerProcessDir branch from 1b34110 to 13fb7dc Compare March 31, 2020 22:10
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@304NotModified 304NotModified merged commit 1599275 into NLog:master Apr 1, 2020
@snakefoot snakefoot mentioned this pull request Apr 1, 2020
Merged
@snakefoot
Copy link
Contributor Author

Created #3877 to make the API consistent.

@snakefoot snakefoot deleted the InternalLoggerProcessDir branch April 4, 2020 12:46
@snakefoot
Copy link
Contributor Author

Updated wiki: https://github.com/NLog/NLog/wiki/Internal-Logging

@snakefoot snakefoot added the documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) label Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@304NotModified 304NotModified 304NotModified approved these changes

Assignees
No one assigned
Labels
documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) enhancement Improvement on existing feature internal-log needs documentation on wiki size/S
Projects
None yet
Milestone
4.7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@snakefoot @304NotModified