Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong warnings on <nlog> element + refactoring #3253

Merged
merged 3 commits into from
Mar 29, 2019
Merged

Fix wrong warnings on <nlog> element + refactoring #3253

merged 3 commits into from
Mar 29, 2019

Conversation

snakefoot
Copy link
Contributor

Resolves #3251

@snakefoot snakefoot mentioned this pull request Mar 28, 2019
Closed
@snakefoot snakefoot force-pushed the LoggingConfigurationParserUnknownChild branch 3 times, most recently from 0acb5cd to 0dca49d Compare March 28, 2019 19:23
@304NotModified
Copy link
Member

While I like refactorings, this change is hard to review that no new bugs are introduced. But I you think this is better than #3254, I'm OK with taking this one.

@snakefoot snakefoot force-pushed the LoggingConfigurationParserUnknownChild branch from 0dca49d to 2531fc5 Compare March 28, 2019 19:58
@codecov
Copy link

codecov bot commented Mar 28, 2019 •
edited
Loading

Codecov Report

Merging #3253 into dev will increase coverage by <1%.
The diff coverage is 85%.

@@          Coverage Diff           @@
##             dev   #3253    +/-   ##
======================================
+ Coverage     80%     80%   +<1%     
======================================
  Files        354     355     +1     
  Lines      27927   28101   +174     
  Branches    3709    3768    +59     
======================================
+ Hits       22265   22466   +201     
+ Misses      4597    4552    -45     
- Partials    1065    1083    +18

@snakefoot snakefoot force-pushed the LoggingConfigurationParserUnknownChild branch from 2531fc5 to c159008 Compare March 28, 2019 20:32
@snakefoot snakefoot force-pushed the LoggingConfigurationParserUnknownChild branch 2 times, most recently from aea5d7c to a849dee Compare March 28, 2019 21:30
@snakefoot snakefoot force-pushed the LoggingConfigurationParserUnknownChild branch from a849dee to 2f554da Compare March 28, 2019 21:49
@304NotModified 304NotModified changed the title LoggingConfigurationParser - Reduce noise from unrecognized configuration elements Fix wrong warnings on <nlog> element Mar 28, 2019
@304NotModified 304NotModified mentioned this pull request Mar 28, 2019
Closed
@304NotModified 304NotModified added this to the 4.6.1 milestone Mar 28, 2019
@304NotModified 304NotModified added the bug Bug report / Bug fix label Mar 28, 2019
@304NotModified 304NotModified changed the title Fix wrong warnings on <nlog> element Fix wrong warnings on <nlog> element + refactoring Mar 28, 2019
@304NotModified 304NotModified merged commit f19db8e into NLog:dev Mar 29, 2019
@snakefoot snakefoot deleted the LoggingConfigurationParserUnknownChild branch April 4, 2020 12:58
@snakefoot snakefoot mentioned this pull request Oct 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@304NotModified 304NotModified 304NotModified approved these changes

Assignees
No one assigned
Labels
bug Bug report / Bug fix nlog-configuration refactoring
Projects
None yet
Milestone
4.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@snakefoot @304NotModified