Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLogLoggingConfiguration - Fix memory-leak when using AutoReload #761

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Aug 23, 2024

Trying to resolve #759 by avoiding double-registration on the config-changed-event.

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.53%. Comparing base (c2875ea) to head (d605cbb).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ensions.Logging/Config/NLogLoggingConfiguration.cs 92.30% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #761      +/-   ##
==========================================
+ Coverage   81.39%   81.53%   +0.14%     
==========================================
  Files          19       19              
  Lines        1806     1809       +3     
  Branches      322      322              
==========================================
+ Hits         1470     1475       +5     
+ Misses        192      190       -2     
  Partials      144      144              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snakefoot
Copy link
Contributor Author

Hooking into FileNamesToWatch and ConfigurationChanged to enable AutoReload feels like a hack.

Think FileNamesToWatch-property should be obsoleted, and removed with NLog v6. Have now made initial step here: NLog/NLog#5577

@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 12, 2024
@snakefoot snakefoot enabled auto-merge (squash) September 12, 2024 18:03
@snakefoot snakefoot merged commit 320ae43 into NLog:master Sep 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NLogLoggingConfiguration leak with auto reload json configuration
2 participants