Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements for .NET Core 2 examples #243

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Enhancements for .NET Core 2 examples #243

merged 1 commit into from
Sep 17, 2018

Conversation

SheepReaper
Copy link
Contributor

additional explanations in the examples, simplified some code, tidied up, and replaced .ReadLine() with .ReadKey() (Since we want to exit with ANY key).

thanks for all the awesome @304NotModified and @snakefoot

… up, and replaced .ReadLine() with .ReadKey() (Since we want to exit with ANY key).
@codecov
Copy link

codecov bot commented Sep 3, 2018

Codecov Report

Merging #243 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #243   +/-   ##
=======================================
  Coverage   71.42%   71.42%           
=======================================
  Files           8        8           
  Lines         448      448           
  Branches      112      112           
=======================================
  Hits          320      320           
  Misses         85       85           
  Partials       43       43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb2f170...5d67f05. Read the comment docs.

@304NotModified 304NotModified changed the title NetCore2 examples enhancements Enhancements for .NET Core 2 examples Sep 17, 2018
@304NotModified 304NotModified added this to the 1.2.2 milestone Sep 17, 2018
@304NotModified 304NotModified merged commit d312930 into NLog:master Sep 17, 2018
@304NotModified
Copy link
Member

Thanks!

@304NotModified 304NotModified modified the milestones: 1.2.2, 1.3 Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants