Skip to content

Commit

Permalink
ConfigureHiddenAssemblies only needed for NetCoreApp1
Browse files Browse the repository at this point in the history
  • Loading branch information
snakefoot committed Feb 22, 2018
1 parent 2599536 commit b4555e3
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/NLog.Extensions.Logging/Extensions/ConfigureExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public static ILoggingBuilder AddNLog(this ILoggingBuilder factory, NLogProvider
/// </summary>
private static void ConfigureHiddenAssemblies()
{
#if NETCORE1_0
#if NETCORE1_0 && !NET451
InternalLogger.Trace("Hide assemblies for callsite");

SafeAddHiddenAssembly("Microsoft.Logging");
Expand All @@ -83,7 +83,7 @@ private static void ConfigureHiddenAssemblies()
#endif
}

#if NETCORE1_0
#if NETCORE1_0 && !NET451
private static void SafeAddHiddenAssembly(string assemblyName, bool logOnException = true)
{
try
Expand Down
7 changes: 7 additions & 0 deletions src/NLog.Extensions.Logging/NLog.Extensions.Logging.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ rc3: Support for .NET 4.6.1, support for message templates .NET standard 1.5+ an
<NetStandardImplicitPackageVersion>1.6.0</NetStandardImplicitPackageVersion>
<DefineConstants>$(DefineConstants);NETCORE1_0</DefineConstants>
</PropertyGroup>
<PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
<Title>NLog.Extensions.Logging for NetStandard 2.0</Title>
</PropertyGroup>
<PropertyGroup Condition=" '$(TargetFramework)' == 'uap10.0' ">
<Title>NLog.Extensions.Logging for UWP</Title>
<NugetTargetMoniker>UAP,Version=v10.0</NugetTargetMoniker>
Expand Down Expand Up @@ -82,4 +85,8 @@ rc3: Support for .NET 4.6.1, support for message templates .NET standard 1.5+ an
<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
<PackageReference Include="Microsoft.Extensions.Logging" Version="2.0.0" />
</ItemGroup>

<PropertyGroup>
<AssemblyTitle>$(Title)</AssemblyTitle>
</PropertyGroup>
</Project>

0 comments on commit b4555e3

Please sign in to comment.