Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation if only feature net is enabled. #412

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

ximon18
Copy link
Member

@ximon18 ximon18 commented Oct 12, 2024

Fixes #411.

@ximon18 ximon18 added the bug Something isn't working label Oct 12, 2024
@ximon18 ximon18 requested a review from a team October 12, 2024 09:38
@ximon18 ximon18 linked an issue Oct 12, 2024 that may be closed by this pull request
@partim partim merged commit 0e16617 into main Oct 14, 2024
26 checks passed
@partim partim deleted the fix-compile-with-feature-net branch October 14, 2024 10:04
partim added a commit that referenced this pull request Oct 14, 2024
New

* Added `Deserialize` impl for the `base::net::nostd::Ipv6Addr` and fixed
  the impl for `Ipv4Addr`. ([#413])

Bug fixes

* Fixed an incorrect feature gate that blocks compilation if only `"net"`
  is enabled. ([#412])
* Added (all? most?) missing feature dependencies for all features.
* Fixed `Deserialize` impls for `ParsedName` and `ExtendedError` to compile
  and work without `std`. ([#413])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

domain 0.10.2 built failed after upgrading
2 participants