visualization blog edits #66
Conversation
There was a problem hiding this comment.
Looks good to me. Sentences are smoother now.
Lots more quotes, some sentences now have a bit to many quotes for me. Feels like every odd word is quoted. Especially line 22, 50, 126, 127
Can you correct the links on the plot images so they point to renamed directory?
| @@ -4,8 +4,8 @@ | |||
| #include "newtonraphson.hpp" | |||
|
|
|||
| int main() { | |||
| double initial_guess = -4; | |||
| double tolerance = 0.001; | |||
| float initial_guess = -4; | |||
| Emscripten can handle simple types like float and int, but needs help exposing more complex types to JavaScript like the iterations property. | ||
| We need to use [value_object](https://emscripten.org/docs/porting/connecting_cpp_and_javascript/embind.html#value-types) to expose the Iteration struct and [register_vector](https://emscripten.org/docs/porting/connecting_cpp_and_javascript/embind.html#built-in-type-conversions) as the iterations property type. | ||
| Emscripten can handle simple types like `float` and `int`, but needs help exposing more complex types to JavaScript like the `iterations` property. | ||
| We need to use [`value_object`](https://emscripten.org/docs/porting/connecting_cpp_and_javascript/embind.html#value-types) to expose the `Iteration` `struct` and [`register_vector`](https://emscripten.org/docs/porting/connecting_cpp_and_javascript/embind.html#built-in-type-conversions) as the `iterations` property type. |
There was a problem hiding this comment.
Links are already rendered differently, they do not need more highlighting
| We need to use [`value_object`](https://emscripten.org/docs/porting/connecting_cpp_and_javascript/embind.html#value-types) to expose the `Iteration` `struct` and [`register_vector`](https://emscripten.org/docs/porting/connecting_cpp_and_javascript/embind.html#built-in-type-conversions) as the `iterations` property type. | |
| We need to use [value_object](https://emscripten.org/docs/porting/connecting_cpp_and_javascript/embind.html#value-types) to expose the `Iteration` `struct` and [register_vector](https://emscripten.org/docs/porting/connecting_cpp_and_javascript/embind.html#built-in-type-conversions) as the `iterations` property type. |
There was a problem hiding this comment.
strictly speaking I don't care to highlight them, but I want to emphasize that I'm referring to something in the code. It's your call though.
|
|
||
| ```shell | ||
| emcc -I. -o newtonraphson.js -Oz -s MODULARIZE=1 \ | ||
| -s EXPORT_NAME=createModule --bind newtonraphson.cpp bindings.cpp | ||
| ``` | ||
|
|
||
| <!-- |
There was a problem hiding this comment.
Ah, I forgot about that one, nice to see #65
…C-JCER/run-cpp-on-web into jspaaks-visualization-edits
Agree, but not quoting them is not the right solution to me |
This PR adds a couple of edits on the visualization blog, mostly style and rephrase and such.