Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature lesson pic #135

Merged
merged 7 commits into from
Dec 18, 2023
Merged

New feature lesson pic #135

merged 7 commits into from
Dec 18, 2023

Conversation

AMOSOMNUM
Copy link
Contributor

No description provided.

@AMOSOMNUM AMOSOMNUM force-pushed the new-feature-lesson-pic branch from 248eb54 to 93a9dac Compare December 15, 2023 08:49
@AMOSOMNUM AMOSOMNUM force-pushed the new-feature-lesson-pic branch from 9ca023a to b90b29f Compare December 16, 2023 08:46
@AMOSOMNUM AMOSOMNUM force-pushed the new-feature-lesson-pic branch from ef0ec0e to 8fdf925 Compare December 17, 2023 04:39
Copy link

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy reports: 2 concern(s)
  • src/domain/model/lesson_model.cpp

    /home/runner/work/SAST-Evento-Desktop/Qt/6.5.0/gcc_64/include/QtCore/qobjectdefs.h:468:9: warning: [clang-analyzer-cplusplus.NewDeleteLeaks]

    Potential memory leak

            return invokeMethodImpl(context,
            ^
    /home/runner/work/SAST-Evento-Desktop/SAST-Evento-Desktop/src/domain/model/lesson_model.cpp:55:5: note: Calling 'QMetaObject::invokeMethod'
        QMetaObject::invokeMethod(
        ^~~~~~~~~~~~~~~~~~~~~~~~~~
    /home/runner/work/SAST-Evento-Desktop/Qt/6.5.0/gcc_64/include/QtCore/qobjectdefs.h:469:33: note: Memory is allocated
                                    new QtPrivate::QFunctorSlotObjectWithNoArgs<Func, decltype(function())>(std::move(function)),
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    /home/runner/work/SAST-Evento-Desktop/Qt/6.5.0/gcc_64/include/QtCore/qobjectdefs.h:468:9: note: Potential memory leak
            return invokeMethodImpl(context,
            ^
  • src/domain/model/type_model.cpp

    /home/runner/work/SAST-Evento-Desktop/Qt/6.5.0/gcc_64/include/QtCore/qobjectdefs.h:468:9: warning: [clang-analyzer-cplusplus.NewDeleteLeaks]

    Potential memory leak

            return invokeMethodImpl(context,
            ^
    /home/runner/work/SAST-Evento-Desktop/SAST-Evento-Desktop/src/domain/model/type_model.cpp:57:5: note: Calling 'QMetaObject::invokeMethod'
        QMetaObject::invokeMethod(
        ^~~~~~~~~~~~~~~~~~~~~~~~~~
    /home/runner/work/SAST-Evento-Desktop/Qt/6.5.0/gcc_64/include/QtCore/qobjectdefs.h:469:33: note: Memory is allocated
                                    new QtPrivate::QFunctorSlotObjectWithNoArgs<Func, decltype(function())>(std::move(function)),
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    /home/runner/work/SAST-Evento-Desktop/Qt/6.5.0/gcc_64/include/QtCore/qobjectdefs.h:468:9: note: Potential memory leak
            return invokeMethodImpl(context,
            ^

Have any feedback or feature suggestions? Share it here.

@Serein207 Serein207 marked this pull request as ready for review December 18, 2023 04:45
@Serein207 Serein207 added the enhancement New feature or request label Dec 18, 2023
@Serein207 Serein207 merged commit 0c03de7 into main Dec 18, 2023
4 of 5 checks passed
@AMOSOMNUM AMOSOMNUM deleted the new-feature-lesson-pic branch December 19, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants