Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components Page #187

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Components Page #187

merged 1 commit into from
Sep 15, 2024

Conversation

thePeras
Copy link
Member

@thePeras thePeras commented Sep 9, 2024

Closes #184
Our simple, but beautiful components page!

Copy link
Collaborator

@toni-santos toni-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very cool and looks phenomenal! Just some small pointers.

@thePeras thePeras force-pushed the feature/components-docs branch from 4a1e9a8 to bdb2b8a Compare September 13, 2024 14:24
@thePeras
Copy link
Member Author

Screenshot 2024-09-13 at 15 25 07

@toni-santos
Copy link
Collaborator

Screenshot 2024-09-13 at 15 25 07

Couldn't we advertise the feedback function of the popup? People are more likely to give feedback if they don't have to send an email and instead just fill a form.

Copy link
Collaborator

@toni-santos toni-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🫡

@thePeras
Copy link
Member Author

Couldn't we advertise the feedback function of the popup? People are more likely to give feedback if they don't have to send an email and instead just fill a form.

I tried, indeed, to open de popup in order to allow the user to fill the form. However, I discover it is impossible to open the popup with JavaScript code, only the user is allowed to manually open it!

@thePeras thePeras merged commit 5c0af44 into develop Sep 15, 2024
@thePeras thePeras deleted the feature/components-docs branch September 15, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Custom Components
2 participants