Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit Test Github Action Workflow #3

Closed
wants to merge 10 commits into from

Conversation

alexju
Copy link

@alexju alexju commented Oct 11, 2024

[Short description explaining the high-level reason for the pull request]

Additions

  • Add Unit Test Run for PR and Push on Master

Removals

Changes

Testing

  1. src/troute-config

Screenshots

Notes

Todos

Checklist

  • [x ] PR has an informative and human-readable title
  • [x ] Changes are limited to a single goal (no scope creep)
  • [x ] Code can be automatically merged (no conflicts)
  • [x ] Code follows project standards (link if applicable)
  • [x ] Passes all existing automated tests
  • [x ] Any change in functionality is tested
  • [x ] New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • [x ] Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • [x ] Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@alexju
Copy link
Author

alexju commented Oct 11, 2024

@taddyb Please review this PR to your development branch.

Copy link
Collaborator

@taddyb taddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the code additions. Lastly, can you change this file name to:
troute-tests.yml to ensure the user knows it's for running tests?


on:
push:
branches: [ "master" ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this to include development as well:

branches: [ "master", "development" ]

Comment on lines 9 to 10
pull_request:
branches: [ "master" ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this to include development as well:

branches: [ "master", "development" ]

run: |
./compiler.sh no-e

- name: Run Unit Test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to
Run T-Route Config Tests

# This workflow will install Python dependencies, build and run tests on the python versions in the matrix.
# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python

name: T-route Unit Test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to:
T-Route Pytests

@alexju
Copy link
Author

alexju commented Oct 12, 2024

Thanks for the code additions. Lastly, can you change this file name to: troute-tests.yml to ensure the user knows it's for running tests?

File name changed.

@alexju
Copy link
Author

alexju commented Oct 15, 2024

@taddyb can you review this pull request when you get a chance?

@taddyb taddyb closed this Nov 6, 2024
taddyb added a commit that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants