-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unit Test Github Action Workflow #3
Conversation
Add Unit Test to Github Action Workflow
Revert "Add Unit Test to Github Action Workflow"
@taddyb Please review this PR to your development branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the code additions. Lastly, can you change this file name to:
troute-tests.yml
to ensure the user knows it's for running tests?
|
||
on: | ||
push: | ||
branches: [ "master" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change this to include development as well:
branches: [ "master", "development" ]
pull_request: | ||
branches: [ "master" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change this to include development as well:
branches: [ "master", "development" ]
run: | | ||
./compiler.sh no-e | ||
|
||
- name: Run Unit Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this to
Run T-Route Config Tests
# This workflow will install Python dependencies, build and run tests on the python versions in the matrix. | ||
# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python | ||
|
||
name: T-route Unit Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this to:
T-Route Pytests
File name changed. |
@taddyb can you review this pull request when you get a chance? |
[Short description explaining the high-level reason for the pull request]
Additions
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other