Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades to RnR: deploying initial states and exception handing in the async framework #6

Merged
5 commits merged into from
Aug 24, 2024

Conversation

ghost
Copy link

@ghost ghost commented Aug 24, 2024

[Short description explaining the high-level reason for the pull request]

Additions

  • Added an initial start parameter to be generated from either:
    • The last observation
    • The first forecast point
  • Added integration for downstream RFC forecasting

Removals

Changes

  • Edited plotting paths to ensure no file errors
  • type casted plot IDs in netcdf file to ensure no mapping errors
  • Edited a broken JSON key path

Testing

Screenshots

image This shows the starting geopackage, and the downstream LID. Flow will be routed from the subset end to the downstream end.
>>>mask = (ds.flow.values != 0).squeeze()
>>> ds.feature_id.values[mask]
array([1060386, 1060387, 1060388, 1060389, 1060390, 1074884, 1074885,
       1074911])
>>> ds.flow.values[mask]
array([[2491.8818],
       [2491.8818],
       [2491.8823],
       [2341.6064],
       [1888.9081],
       [2491.8823],
       [2491.8823],
       [2491.8823]], dtype=float32)

and flow is being propagated through the network

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@ghost ghost merged commit eff5774 into development Aug 24, 2024
4 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant