This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
DO-5053 allow additional properties on connection #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! |
|
update
|
jcready
reviewed
Aug 22, 2020
tirish
approved these changes
Aug 24, 2020
ojintoad
commented
Aug 24, 2020
…n' of https://github.com/NGPVAN/amqp.channel into devops/DO-5053-allow-additional-properties-on-connection
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pairs with https://github.com/NGPVAN/advocator/pull/1029 see testing there
Moar details, this is based on the fix reported in: amqp-node/amqplib#331
Need this for SNI correctness and node requires it: nodejs/node#28167 (comment)