-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parameter file updates #862
Merged
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
eaf52a7
Added hydr_solver and stomatal_assim switches to parameter file
rgknox 1879333
converting parameter crown to crown_depth_frac and forcing its use th…
rgknox 3a7e083
Added new param fields for phenology and damage
rgknox 8e85fb1
Sorted fates default param file
rgknox 5e60f74
Added new maxpatch and harvest production parameters.
rgknox 4d66d49
Updating naming convention of nutrient enabled (CNP) allocation param…
rgknox f64861e
Added maxpatch to parameter file, updated damage bin widths for history
rgknox c7d048c
First version of the parameter API updater
rgknox 7912585
Parameter file API updater script is nearly final, incremental progre…
rgknox d321625
tweaks to parameter api change couplet
rgknox 954e343
minor updates to fates default parameters api24
rgknox d14ae29
Removing parameter file api24 default v1
rgknox 1fbd6d0
Updated some parameter names to be more verbose
rgknox d77e7b8
Adding model-side changes to the parameter file parameter names. Cha…
rgknox a14a31f
Changing some phen parameters to pft level, adding damage codes
rgknox 5c8c58b
Reverted pft-scale phen parameters back to scalar because the phenolo…
rgknox 735b33f
Addition of damage history dimensioning, and module flag
rgknox 64f6c71
Removing export frac check
rgknox 14fdfe2
minor conflict resolution
rgknox 401cb25
Minor syntax updates
rgknox dbd00f4
Syntax changes, minor
rgknox 8c85f90
Removing stoich_p2 variables
rgknox ce4821b
Small adjustments to parameter update pr, including setting secondary…
rgknox e3972d7
merge resolution
rgknox 11b393c
Updating the default parameter file to api 24
rgknox 380b298
Update the default parameter file
rgknox 6513ff2
Conflict resolutions between the parameter file updates and syntax ch…
rgknox 808e38f
changed array indices to use names indices
rgknox 8078435
Reverting changes to EDCanopyStructureMod for b4b
rgknox 7182c2c
minor fix, removed old maxcohort declaration
rgknox a1ec3b2
fixed maxCohorts
rgknox 6c4c060
Merge branch 'params-maxpatch-logfinal' of github.com:rgknox/fates in…
rgknox d3d5b83
Copied fates_params_default_api24.cdl over to the default file
rgknox 4c01c5a
Removing the api24 temporary default parameter file
rgknox f054c85
Conflict resolution between the parameter update and parteh loop sele…
rgknox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Small adjustments to parameter update pr, including setting secondary…
… patches to 4 in the xml update file.
- Loading branch information
commit ce4821b362f5db5741b0602064273c8cecaf17b7
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find this in the issue discussion. What predicated the removal of these parameters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a defensible way of having plasticity in nutrient concentrations yet, so this parameter is not useful. @jenniferholm has been investigating such a feature though, so this may change down the line. In the future depending on those findings we could introduce the necessary parameters. My sense is that when we do, the plasticity will not be introduced through this parameter, and may target individual organs that actually experience plasticity, like leaves.