fire-hydro bug fix #665
Merged
fire-hydro bug fix #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgknox
reviewed
Jun 21, 2020
| @@ -141,7 +141,7 @@ subroutine fire_danger_index ( currentSite, bc_in) | |||
| d_NI = 0.0_r8 | |||
| currentSite%acc_NI = 0.0_r8 | |||
| else | |||
| yipsolon = (SF_val_fdi_a* temp_in_C)/(SF_val_fdi_b+ temp_in_C)+log(rh/100.0_r8) | |||
| yipsolon = (SF_val_fdi_a* temp_in_C)/(SF_val_fdi_b+ temp_in_C)+log(max(1.0_r8,rh)/100.0_r8) | |||
There was a problem hiding this comment.
I'm surprised that this was necessary. RH<1 is incredibly dry, almost impossible. How low are the values seen here?
|
Tests on cheyenne look good. All b4b except for some fire related diagnostics on a long test (which should theoretically be different given the changes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixed a bug that prevent the simultaneous run of hydro and fire (#654)
Collaborators:
@JunyanDing @jkshuman @ckoven
Expectation of Answer Changes:
This will allow the model to run both hydro and fire models.
Checklist:
Test Results:
The model run successfully for ELM(FATES).
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: