Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate parameter file switches that are moving to HLM namelist #1300

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

glemieux
Copy link
Contributor

@glemieux glemieux commented Dec 11, 2024

Addresses #1295

To be coordinated with ESCOMP/CTSM#2904

Description:

Parameter switches to be moved:

  • fates_daylength_factor_switch
  • fates_hydro_solver
  • fates_leaf_photo_tempsens_model
  • fates_leaf_stomatal_assim_model
  • fates_leaf_stomatal_model
  • fates_maintresp_leaf_model
  • fates_mort_cstarvation_model
  • fates_rad_model
  • fates_regeneration_model

Collaborators:

Expectation of Answer Changes:

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@glemieux glemieux force-pushed the parameter-switch-migration branch from 67e0842 to e8ae746 Compare December 11, 2024 19:41
@glemieux glemieux force-pushed the parameter-switch-migration branch 4 times, most recently from fb6bd7a to c89b770 Compare December 11, 2024 22:57
@glemieux glemieux force-pushed the parameter-switch-migration branch from c89b770 to ef51623 Compare December 12, 2024 19:29
@glemieux glemieux marked this pull request as ready for review December 12, 2024 20:20
@rgknox
Copy link
Contributor

rgknox commented Dec 16, 2024

Noting that we have concurrent plans to change the hydro solver default, possibly the respiration default, or others. This is just a reminder to make sure that those changes do not get lost in the shuffle.

@@ -1858,33 +1856,6 @@ subroutine FatesCheckParams(is_master)

if(.not.is_master) return

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that we have xml level guardrails on valid namelist inputs, so we don't need to add these checks somewhere else.
https://github.com/ESCOMP/CTSM/pull/2904/files#diff-3e692a9856bdea4592f7a24859b6967201505af3780e800abe3d906c8b7ef7adR778

@glemieux glemieux added the parameter file Pertaining to changes to the FATES parameter file label Jan 13, 2025
This is associated with the hlm-side change from logical to named switch
@glemieux
Copy link
Contributor Author

Noting that we have concurrent plans to change the hydro solver default, possibly the respiration default, or others. This is just a reminder to make sure that those changes do not get lost in the shuffle.

Roger that. @rgknox @ekluzek I'd like to try and make #1263 the fates tag immediately prior to #1300 (and ESCOMP/CTSM#2904) so we can update the default parameter file and capture the hydro solver default change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parameter file Pertaining to changes to the FATES parameter file
Projects
Status: Final Testing
Development

Successfully merging this pull request may close these issues.

Migrate fates parameter file switches to HLM namelist
2 participants