Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hydraulics sensitivity to crown depth #789

Open
rgknox opened this issue Oct 4, 2021 · 1 comment
Open

hydraulics sensitivity to crown depth #789

rgknox opened this issue Oct 4, 2021 · 1 comment

Comments

@rgknox
Copy link
Contributor

rgknox commented Oct 4, 2021

FATES currently uses two different ways to estimate crown depth, for different routines.

For calculating crown fires and snow occlusion of leaves, it uses the fates_fire_crown_depth_frac parameter, where:

crown_depth = crown_depth_frac * height

For hydraulics, it assumes the crown depth is the minimum of 1 meter and the height of the plant:

crown_depth = min(1.0, height)

Through efforts on #738, @JunyanDing and I tested the effects of unifying the scheme, so that hydraulics use the first approach. This change will be withheld from PR #738 , but we wanted to discuss these alternatives and if/how we should change. The differences in results between using the two schemes were noticeable. The following is a simple comparison at BCI, between master, and a version that migrates hydrualics to use the first formulation of crown depth. ST3 mode is also turned on.

rootdepth-v3-st3_plots.pdf

@rgknox rgknox changed the title hyuraulics sensitivity to crown depth hydraulics sensitivity to crown depth Oct 4, 2021
@xuchongang
Copy link
Contributor

@rgknox , I think it would be great to make hydro code consistent with the other codes. It should not have much impact on the hydrodynamics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants