order of promotion and demotion

[rgknox]

In EDCanopyStructure.F90:canopy_structure(), cohorts are split and partially demoted to lower layers if the layer they live in is too full. After which, we look top down at which layers are not full, and promote cohorts from lower layers into the one above.

I think the order of operations here matters. The reason, is that since we impose a hard cap on how many layers we are willing to accept, we end up killing understorey plants during the demotion phase, if the lowest allowable layer has too much crown area. It is possible that if we promoted first, the understorey area would had been relaxed, and we would not have had to kill off understorey plants to meet space requirements.

Note: I don't think this is a bug, and I don't think this has anything to do with #267.

[rosiealice]

Is this related to the hanging issue, do you think, or is it orthogonal, or do we not know?

…

On 6 September 2017 at 14:07, Ryan Knox ***@***.***> wrote: In EDCanopyStructure.F90:canopy_structure(), cohorts are split and partially demoted to lower layers if the layer they live in is too full. After which, we look top down at which layers are not full, and promote cohorts from lower layers into the one above. I think the order of operations here matters. The reason, is that since we impose a hard cap on how many layers we are willing to accept, we end up killing understorey plants during the demotion phase, if the lowest allowable layer has too much crown area. It is possible that if we promoted first, the understorey area would had been relaxed, and we would not have had to kill off understorey plants to meet space requirements. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#269>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMWsQ73aviQFYQ6dqbR2hFTT1MMZE5E5ks5sfvuegaJpZM4PO5ye> .

-- ----------------------------------------------------------------- Dr Rosie A. Fisher Staff Scientist Terrestrial Sciences Section Climate and Global Dynamics National Center for Atmospheric Research 1850 Table Mesa Drive Boulder, Colorado, 80305 USA. +1 303-497-1706 http://www.cgd.ucar.edu/staff/rfisher/

[rgknox]

I don't think it has anything to do with the hanging. I think its more of a science thing than a bug thing.

[rgknox]

fixed via #501