Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:space): fix deprecated warning for nz-space-item (#6549) #6561

Merged
merged 1 commit into from
Apr 3, 2021

Conversation

lsbbd
Copy link
Contributor

@lsbbd lsbbd commented Mar 27, 2021

closes #6549

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #6549

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@lsbbd lsbbd requested a review from hsuanxyz as a code owner March 27, 2021 16:34
@zorro-bot
Copy link

zorro-bot bot commented Mar 27, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #6561 (4f24e54) into master (bc0e468) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4f24e54 differs from pull request most recent head e313656. Consider uploading reports for the commit e313656 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6561      +/-   ##
==========================================
- Coverage   89.88%   89.87%   -0.01%     
==========================================
  Files         481      481              
  Lines       15374    15374              
  Branches     2343     2486     +143     
==========================================
- Hits        13819    13818       -1     
  Misses        937      937              
- Partials      618      619       +1     
Impacted Files Coverage Δ
components/space/space.component.ts 100.00% <100.00%> (ø)
components/time-picker/time-holder.ts 94.73% <0.00%> (-1.06%) ⬇️
components/tabs/tab-nav-bar.component.ts 82.39% <0.00%> (-0.71%) ⬇️
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc0e468...e313656. Read the comment docs.

@vthinkxie vthinkxie merged commit f80a5bb into NG-ZORRO:master Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting warning about deprecated nz-space-item even when not using them
2 participants