Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:message): avoid flicker when window close (#6296) #6370

Merged
merged 1 commit into from
Feb 13, 2021
Merged

fix(module:message): avoid flicker when window close (#6296) #6370

merged 1 commit into from
Feb 13, 2021

Conversation

xiejay97
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: resolve #6296

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xiejay97 xiejay97 requested a review from wzhudev as a code owner January 22, 2021 09:58
@zorro-bot
Copy link

zorro-bot bot commented Jan 22, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #6370 (30ef458) into master (8233dc4) will decrease coverage by 0.04%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6370      +/-   ##
==========================================
- Coverage   89.88%   89.84%   -0.05%     
==========================================
  Files         478      478              
  Lines       15270    15287      +17     
  Branches     2326     2326              
==========================================
+ Hits        13725    13734       +9     
- Misses        929      934       +5     
- Partials      616      619       +3     
Impacted Files Coverage Δ
components/message/message.component.ts 100.00% <ø> (ø)
components/notification/notification.component.ts 100.00% <ø> (ø)
components/message/base.ts 87.39% <72.72%> (-1.60%) ⬇️
components/typography/text-edit.component.ts 95.12% <0.00%> (-2.38%) ⬇️
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/tabs/tab-nav-bar.component.ts 82.39% <0.00%> (-0.71%) ⬇️
components/modal/utils.ts 100.00% <0.00%> (ø)
components/modal/modal-types.ts 100.00% <0.00%> (ø)
components/upload/upload.component.ts 94.35% <0.00%> (ø)
components/upload/upload-list.component.ts 95.86% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8233dc4...30ef458. Read the comment docs.

@vthinkxie vthinkxie merged commit 772e76c into NG-ZORRO:master Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

消息弹框消失时突然闪动一下
2 participants