-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:form): nz-form-label
support nzFormTooltip
#5957
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #5957 +/- ##
==========================================
+ Coverage 89.92% 89.98% +0.05%
==========================================
Files 463 465 +2
Lines 13965 14045 +80
Branches 2289 2309 +20
==========================================
+ Hits 12558 12638 +80
+ Misses 867 859 -8
- Partials 540 548 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
非 string 时,是不是结构化指令更灵活一些?
<nz-form-label>
Label
<i *nzFormTooltip nz-icon nz-tooltip></i>
</nz-form-label>
@hsuanxyz 这样的话,nzFormTooltip 只是加一个 class 吗?那好像意义也不是很大?不使用这个 API 代码量也差不多。 我认为可能更多的使用方式还是这种更好些? <nz-form-label [nzFormTooltip]="{ title: 'title', icon: 'info-circle'}">
Label
</nz-form-label> |
如果还有更复杂的需求的话,用户就不用这个 API ,完全自己手写好了。:eyes: |
@hsuanxyz 好、那就在全局配置里加一个 👀, 是我 vue 写多了嘛?怎么老搞这种联合类型出来。 |
@danranVm 😂 一个也行,只是 merge 的时候要多判断一下 |
close #5905
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information