-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:spin): make delay behave more accurately #5930
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5930 +/- ##
==========================================
- Coverage 90.02% 90.00% -0.03%
==========================================
Files 463 463
Lines 13948 13947 -1
Branches 2202 2202
==========================================
- Hits 12557 12553 -4
- Misses 856 857 +1
- Partials 535 537 +2
Continue to review full report at Codecov.
|
Accidentally disabled most tests, will fix this in a bit. |
This also cleans up the rxjs in this component which would actually create a memory leak over time if the delay input changes a lot (which is very hypothetical). fixes NG-ZORRO#5926
36f92c6
to
183dab1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work @Airblader
😭 Deploy PR Preview 5c901a0 failed. Build logs 🤖 By surge-preview |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
If you don't agree with either change let me know and I can update the PR.
Does this PR introduce a breaking change?
fixes #5926
fixes #5928