Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:datapicker): add [nzInputReadOnly] #5488

Conversation

DeckardCainCN
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4534

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@DeckardCainCN DeckardCainCN requested a review from wenqi73 as a code owner June 30, 2020 12:12
@zorro-bot
Copy link

zorro-bot bot commented Jun 30, 2020

This preview will be available after the AzureCI is passed.

@DeckardCainCN
Copy link
Contributor Author

DeckardCainCN commented Jun 30, 2020

@wenqi73 不好意思。由于我这边直接在对话上修改,导致 CI 没过。后又操作 git reset --hard 误将修改丢失。故这边重开了一个 PR。

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #5488 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5488      +/-   ##
==========================================
+ Coverage   91.15%   91.20%   +0.04%     
==========================================
  Files         453      453              
  Lines       13880    13882       +2     
  Branches     2206     2206              
==========================================
+ Hits        12653    12661       +8     
+ Misses        727      721       -6     
  Partials      500      500              
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 96.52% <100.00%> (+0.02%) ⬆️
components/date-picker/picker.component.ts 96.22% <100.00%> (+0.02%) ⬆️
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️
components/table/src/table/tr-measure.component.ts 100.00% <0.00%> (+13.04%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 074a3da...156556e. Read the comment docs.

Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz changed the title feat(module:datapicker): add [nzInputReadOnly] (#4534) feat(module:datapicker): add [nzInputReadOnly] Jul 2, 2020
@vthinkxie vthinkxie merged commit 13875cb into NG-ZORRO:master Jul 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants