-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:calendar): support only display date of active month #5146
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #5146 +/- ##
==========================================
- Coverage 91.45% 91.42% -0.04%
==========================================
Files 547 547
Lines 13746 13804 +58
Branches 2129 2151 +22
==========================================
+ Hits 12572 12620 +48
- Misses 709 712 +3
- Partials 465 472 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your pull request!
some comments here:
- The issue is needed before creating any pull request, this would help others understand your proposal.
- test is needed
Actually, the issue is exist #4615 |
Issue number has been displaied in the PR describe. And I added a unit test for this feature just now. |
Any problems? |
cc @wenqi73 |
@Mr-Eve 只需要加个 |
确实. 那过两天我看看. 我重新提PR吧, 这个PR的commit都没有价值了. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #4615
What is the new behavior?
If you enable
nzMonthScope
(defaultfalse
), then calendar only display the date of active month, not display extra date anymore.Does this PR introduce a breaking change?
Other information