Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:calendar): support only display date of active month #5146

Closed
wants to merge 4 commits into from
Closed

feat(module:calendar): support only display date of active month #5146

wants to merge 4 commits into from

Conversation

Eve-Sama
Copy link
Contributor

@Eve-Sama Eve-Sama commented Apr 25, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4615

What is the new behavior?

If you enable nzMonthScope(default false), then calendar only display the date of active month, not display extra date anymore.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 25, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #5146 into master will decrease coverage by 0.03%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5146      +/-   ##
==========================================
- Coverage   91.45%   91.42%   -0.04%     
==========================================
  Files         547      547              
  Lines       13746    13804      +58     
  Branches     2129     2151      +22     
==========================================
+ Hits        12572    12620      +48     
- Misses        709      712       +3     
- Partials      465      472       +7     
Impacted Files Coverage Δ
components/date-picker/lib/date-table.component.ts 96.61% <90.00%> (-0.62%) ⬇️
components/calendar/calendar.component.ts 100.00% <100.00%> (ø)
components/table/src/table/tbody.component.ts 85.71% <0.00%> (-14.29%) ⬇️
components/table/src/table/tr-measure.component.ts 86.95% <0.00%> (-13.05%) ⬇️
...s/notification/notification-container.component.ts 94.23% <0.00%> (-5.77%) ⬇️
components/time-picker/time-holder.ts 94.73% <0.00%> (-1.06%) ⬇️
components/message/base.ts 88.78% <0.00%> (-0.84%) ⬇️
components/select/select.component.ts 90.14% <0.00%> (-0.47%) ⬇️
components/input/input.module.ts 100.00% <0.00%> (ø)
components/select/select.module.ts 100.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c938b4...3cc6b07. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request!
some comments here:

  1. The issue is needed before creating any pull request, this would help others understand your proposal.
  2. test is needed

@Eve-Sama
Copy link
Contributor Author

Thanks for your pull request!
some comments here:

1. The issue is needed before creating any pull request, this would help others understand your proposal.

2. test is needed

Actually, the issue is exist #4615

@Eve-Sama
Copy link
Contributor Author

Thanks for your pull request!
some comments here:

1. The issue is needed before creating any pull request, this would help others understand your proposal.

2. test is needed

Issue number has been displaied in the PR describe. And I added a unit test for this feature just now.

@Eve-Sama Eve-Sama requested a review from vthinkxie April 27, 2020 14:35
@Eve-Sama
Copy link
Contributor Author

Eve-Sama commented May 3, 2020

Any problems?

@vthinkxie
Copy link
Member

cc @wenqi73
can you take a look?

@wenqi73
Copy link
Member

wenqi73 commented May 3, 2020

@Mr-Eve 只需要加个 [nzDisabledDate] 即可。“仅显示当前月的日期”这种定制化的需求不是组件库应该做的。正如 issue 里面所说,用 [nzDisabledDate] 配合 css 就能解决该需求。欢迎再来个 PR!

@Eve-Sama
Copy link
Contributor Author

Eve-Sama commented May 4, 2020

确实. 那过两天我看看. 我重新提PR吧, 这个PR的commit都没有价值了.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants