Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:i18n): fix Russian i18n file #4111

Merged
merged 2 commits into from
Sep 3, 2019
Merged

fix(module:i18n): fix Russian i18n file #4111

merged 2 commits into from
Sep 3, 2019

Conversation

Svetomechc
Copy link
Contributor

@Svetomechc Svetomechc commented Sep 3, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4080

What is the new behavior?

Fixed compilation errors when using ru_RU locale.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@wzhudev
Copy link
Member

wzhudev commented Sep 3, 2019

@Svetomechc Could you please update these values as well?

Icon: {
},
Text: {
},

@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #4111 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4111   +/-   ##
======================================
  Coverage    92.4%   92.4%           
======================================
  Files         506     506           
  Lines       10759   10759           
  Branches     1940    1940           
======================================
  Hits         9942    9942           
  Misses        402     402           
  Partials      415     415

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e76e37...258477e. Read the comment docs.

@Svetomechc
Copy link
Contributor Author

@wendzhue that better?

@netlify
Copy link

netlify bot commented Sep 3, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 258477e

https://deploy-preview-4111--ng-zorro-master.netlify.com

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit f267bdd into NG-ZORRO:master Sep 3, 2019
@vthinkxie vthinkxie changed the title Update ru_RU.ts fix(module:i18n): fix Russian i18n file Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants