Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:modal): integrate with tabs and autosize #3065

Merged
merged 3 commits into from
Mar 20, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2286, #2713

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #3065 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3065      +/-   ##
==========================================
+ Coverage   97.32%   97.34%   +0.01%     
==========================================
  Files         550      550              
  Lines       11510    11514       +4     
  Branches      819      822       +3     
==========================================
+ Hits        11202    11208       +6     
+ Misses        199      197       -2     
  Partials      109      109
Impacted Files Coverage Δ
components/input/nz-input.module.ts 100% <100%> (ø) ⬆️
components/input/nz-autosize.directive.ts 97.56% <100%> (ø)
components/select/nz-select.component.ts 98.01% <0%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 494e18f...206e4c6. Read the comment docs.

@netlify
Copy link

netlify bot commented Mar 11, 2019

Deploy preview for ng-zorro-master ready!

Built with commit c7f461f

https://deploy-preview-3065--ng-zorro-master.netlify.com

@netlify
Copy link

netlify bot commented Mar 11, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 206e4c6

https://deploy-preview-3065--ng-zorro-master.netlify.com

@hsuanxyz hsuanxyz changed the title fix(module:modal): integrate with tabs and auto-size fix(module:modal): integrate with tabs and autosize Mar 14, 2019
@simplejason simplejason self-requested a review March 20, 2019 11:44
@simplejason simplejason merged commit 4cab26f into NG-ZORRO:master Mar 20, 2019
@hsuanxyz hsuanxyz deleted the modal-integrate branch April 22, 2019 02:39
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* fix(module:modal): integrate with tabs and auto-size

* fix(module:autosize): bug in modal

* test(module:autosize): add resize test case

close NG-ZORRO#2286, close NG-ZORRO#2713
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* fix(module:modal): integrate with tabs and auto-size

* fix(module:autosize): bug in modal

* test(module:autosize): add resize test case

close NG-ZORRO#2286, close NG-ZORRO#2713
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants