-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:upload): fix parameter value muse be a function or boolean in nzRemove #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrade laster version
latest version
… in nzRemove examples: ```ts true; false; (file: UploadFile) => true; (file: UploadFile) => false; (file: UploadFile) => of(true); (file: UploadFile) => of(false); ```
Codecov Report
@@ Coverage Diff @@
## master #1851 +/- ##
==========================================
- Coverage 96.07% 96.07% -0.01%
==========================================
Files 466 466
Lines 11173 11175 +2
Branches 1461 1462 +1
==========================================
+ Hits 10735 10736 +1
Misses 126 126
- Partials 312 313 +1
Continue to review full report at Codecov.
|
vthinkxie
approved these changes
Jul 22, 2018
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Jul 22, 2018
wenqi73
pushed a commit
to wenqi73/ng-zorro-antd
that referenced
this pull request
Aug 27, 2018
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1850
What is the new behavior?
Does this PR introduce a breaking change?
Other information