Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:auto-complete, mention, tree-select): update cdk overlay positioning strategy #1761

Merged

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1756

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@hsuanxyz hsuanxyz requested a review from vthinkxie June 30, 2018 13:26
@codecov
Copy link

codecov bot commented Jun 30, 2018

Codecov Report

Merging #1761 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1761   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files         466      466           
  Lines       11146    11146           
  Branches     1456     1456           
=======================================
  Hits        10706    10706           
  Misses        127      127           
  Partials      313      313
Impacted Files Coverage Δ
components/mention/mention.component.ts 99.41% <100%> (ø) ⬆️
...auto-complete/nz-autocomplete-trigger.directive.ts 96.68% <100%> (ø) ⬆️
components/tree-select/nz-tree-select.component.ts 99.03% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4005c7c...3dc02b2. Read the comment docs.

@vthinkxie vthinkxie merged commit 82af2ff into NG-ZORRO:master Jul 1, 2018
@hsuanxyz hsuanxyz deleted the tree-select/fix-firefox-position branch July 1, 2018 07:01
wenqi73 pushed a commit to wenqi73/ng-zorro-antd that referenced this pull request Aug 27, 2018
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants