Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tree-select): position error when in the modal-box #1687

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1681

What is the new behavior?

reposition when open.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@hsuanxyz hsuanxyz requested a review from simplejason June 20, 2018 03:38
@codecov
Copy link

codecov bot commented Jun 20, 2018

Codecov Report

Merging #1687 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1687      +/-   ##
==========================================
+ Coverage   96.01%   96.02%   +<.01%     
==========================================
  Files         466      466              
  Lines       11091    11093       +2     
  Branches     1462     1462              
==========================================
+ Hits        10649    10652       +3     
  Misses        125      125              
+ Partials      317      316       -1
Impacted Files Coverage Δ
components/tree-select/nz-tree-select.component.ts 99.03% <100%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a4332a...d453c88. Read the comment docs.

@vthinkxie vthinkxie merged commit 43910f9 into NG-ZORRO:master Jun 22, 2018
@hsuanxyz hsuanxyz deleted the tree-select/fix-position branch July 1, 2018 07:01
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants