Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:input-number): fix focused style could not be removed after blur #1453

Merged
merged 3 commits into from
May 22, 2018

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented May 16, 2018

fix(module:input-number): fix focused style could not be removed after blur (#1449). The reason was when up/down button is clicked, the input is not focused, so it won't emit blur event to remove focused style. Fixed by manually focusing it.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

After clicking the up/down button of a nz-input-number without focusing it, clicking outside of the nz-input-number would not remove its focused style.

Issue Number: 1449

What is the new behavior?

After clicking the up/down button of a nz-input-number without focusing it, clicking outside of the nz-input-number would remove its focused style.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

…r blur (NG-ZORRO#1449)

fix(module:input-number): fix focused style could not be removed after blur (NG-ZORRO#1449). The reason was when up/down button is clicked, the input is not focused, so I won't emit blur event to remove focused style. Fixed by manually focusing it.
@vthinkxie
Copy link
Member

ci has some problems now, we will fix it later.

@codecov
Copy link

codecov bot commented May 16, 2018

Codecov Report

Merging #1453 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1453      +/-   ##
==========================================
+ Coverage   96.91%   96.92%   +0.01%     
==========================================
  Files         222      222              
  Lines        9488     9499      +11     
  Branches     1293     1296       +3     
==========================================
+ Hits         9195     9207      +12     
+ Misses         43       42       -1     
  Partials      250      250
Impacted Files Coverage Δ
...mponents/input-number/nz-input-number.component.ts 98.98% <100%> (+0.02%) ⬆️
components/message/nz-message.service.ts 97.95% <0%> (+0.08%) ⬆️
...auto-complete/nz-autocomplete-trigger.directive.ts 96.64% <0%> (+0.11%) ⬆️
components/table/nz-table.component.ts 95.48% <0%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78ac404...f58e323. Read the comment docs.

@vthinkxie
Copy link
Member

and you need to add test case when fixing bugs.

@wzhudev
Copy link
Member Author

wzhudev commented May 17, 2018

@vthinkxie I have added a test case. But I can't test it because of the CI problem you mentioned. Should I do something to fix that?

It says:

17 05 2018 13:43:24.825:WARN [Chrome 66.0.3359 (Mac OS X 10.13.4)]: Disconnected (1 times), because no message in 10000 ms.
Chrome 66.0.3359 (Mac OS X 10.13.4) ERROR
  Disconnected, because no message in 10000 ms.

Chrome 66.0.3359 (Mac OS X 10.13.4) ERROR
  Disconnected, because no message in 10000 ms.
Chrome 66.0.3359 (Mac OS X 10.13.4) ERROR
  Disconnected, because no message in 10000 ms.

@wzhudev
Copy link
Member Author

wzhudev commented May 17, 2018

And Travis was stuck on npm install @angular/cli for no good reason. Shall I try again later and fix code styling?

@vthinkxie
Copy link
Member

I just restart it.

@wzhudev
Copy link
Member Author

wzhudev commented May 22, 2018

@vthinkxie I tested it and it worked. I think we are good to go after the ci problem is solved.

@vthinkxie
Copy link
Member

@wendzhue ,yes there is something wrong with test in travis now, and everything works fine in local env.

@vthinkxie vthinkxie merged commit 80a559f into NG-ZORRO:master May 22, 2018
@wzhudev wzhudev deleted the fix-number-input branch June 28, 2018 23:55
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants