-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:input-number): fix focused style could not be removed after blur #1453
Conversation
…r blur (NG-ZORRO#1449) fix(module:input-number): fix focused style could not be removed after blur (NG-ZORRO#1449). The reason was when up/down button is clicked, the input is not focused, so I won't emit blur event to remove focused style. Fixed by manually focusing it.
ci has some problems now, we will fix it later. |
Codecov Report
@@ Coverage Diff @@
## master #1453 +/- ##
==========================================
+ Coverage 96.91% 96.92% +0.01%
==========================================
Files 222 222
Lines 9488 9499 +11
Branches 1293 1296 +3
==========================================
+ Hits 9195 9207 +12
+ Misses 43 42 -1
Partials 250 250
Continue to review full report at Codecov.
|
and you need to add test case when fixing bugs. |
@vthinkxie I have added a test case. But I can't test it because of the CI problem you mentioned. Should I do something to fix that? It says:
|
And Travis was stuck on |
I just restart it. |
@vthinkxie I tested it and it worked. I think we are good to go after the ci problem is solved. |
@wendzhue ,yes there is something wrong with test in travis now, and everything works fine in local env. |
fix(module:input-number): fix focused style could not be removed after blur (#1449). The reason was when up/down button is clicked, the input is not focused, so it won't emit blur event to remove focused style. Fixed by manually focusing it.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
After clicking the up/down button of a
nz-input-number
without focusing it, clicking outside of thenz-input-number
would not remove its focused style.Issue Number: 1449
What is the new behavior?
After clicking the up/down button of a
nz-input-number
without focusing it, clicking outside of thenz-input-number
would remove its focused style.Does this PR introduce a breaking change?
Other information