Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nz-cascader nzClear not working or implemented #6751

Closed
chriso86 opened this issue Jun 9, 2021 · 3 comments · Fixed by #6761
Closed

nz-cascader nzClear not working or implemented #6751

chriso86 opened this issue Jun 9, 2021 · 3 comments · Fixed by #6761

Comments

@chriso86
Copy link
Contributor

chriso86 commented Jun 9, 2021

Reproduction link

@Output() readonly nzClear = new EventEmitter<void>();

Steps to reproduce

Try to consume the EventEmitter for nz-cascader called nzClear.

What is expected?

It should emit to the consumer of the component using the nzClear event emitter somewhere, probably in the clearSelection method:
cascader.component.ts line 466

What is actually happening?

It doesn't emit anything.

Environment Info
ng-zorro-antd 11.4.2
Browser Chrome (Doesn't matter)

I searched through the cascader service and found a method called prepareEmitValue, but nzClear is never emitted anywhere as far as I'm able to see.

@zorro-bot
Copy link

zorro-bot bot commented Jun 9, 2021

Hello @chriso86. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please fill the Pull Request Template here, provide documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @chriso86, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请务必填写 Pull Request 内的预设模板,提供改动所需相应的测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!
giphy

@wzhudev
Copy link
Member

wzhudev commented Jun 9, 2021

PR is welcomed!

@chriso86
Copy link
Contributor Author

chriso86 commented Jun 9, 2021

@wendellhu95 Okay cool, I'll make the change now and create the PR. Do I create the PR to "master" branch? What is your ALM model for a fix like this? Do you have a QAS channel?

hsuanxyz pushed a commit that referenced this issue Jun 11, 2021
Add the missing nzClear emit to the clearSelection method on the cascader component.
Extend the cascader e2e tests to ensure that the event emitter works as expected.

fix #6751
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants