You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Try to consume the EventEmitter for nz-cascader called nzClear.
What is expected?
It should emit to the consumer of the component using the nzClear event emitter somewhere, probably in the clearSelection method: cascader.component.ts line 466
What is actually happening?
It doesn't emit anything.
Environment
Info
ng-zorro-antd
11.4.2
Browser
Chrome (Doesn't matter)
I searched through the cascader service and found a method called prepareEmitValue, but nzClear is never emitted anywhere as far as I'm able to see.
The text was updated successfully, but these errors were encountered:
Hello @chriso86. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please fill the Pull Request Template here, provide documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!
@wendellhu95 Okay cool, I'll make the change now and create the PR. Do I create the PR to "master" branch? What is your ALM model for a fix like this? Do you have a QAS channel?
Add the missing nzClear emit to the clearSelection method on the cascader component.
Extend the cascader e2e tests to ensure that the event emitter works as expected.
fix#6751
Reproduction link
ng-zorro-antd/components/cascader/cascader.component.ts
Line 252 in ab63d7e
Steps to reproduce
Try to consume the EventEmitter for nz-cascader called nzClear.
What is expected?
It should emit to the consumer of the component using the nzClear event emitter somewhere, probably in the clearSelection method:
cascader.component.ts line 466
What is actually happening?
It doesn't emit anything.
I searched through the cascader service and found a method called prepareEmitValue, but nzClear is never emitted anywhere as far as I'm able to see.
The text was updated successfully, but these errors were encountered: