Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date range picker shows start and end month togehter, even if they are not one after the other #6142

Closed
idan-codefresh opened this issue Dec 3, 2020 · 0 comments · Fixed by #6339
Closed

Date range picker shows start and end month togehter, even if they are not one after the other #6142

idan-codefresh opened this issue Dec 3, 2020 · 0 comments · Fixed by #6339
Assignees
@wenqi73
Labels
Component: DatePicker
Milestone
v11.0.0

Comments

@idan-codefresh
Copy link

Reproduction link

https://nfe7js--run.stackblitz.io

Steps to reproduce

Open the angular version
https://nfe7js--run.stackblitz.io

select start date and select end date to be not from the next month but three or four months ahead, so start date 1.11.2020 end date 1.5.2021
dialog will close.
after you click again on the date picker on the start date, the monthly selection will have Nov 2020 on the left side (start date) and May 2021 on the right side (end date) next to it.
this is wrong we should show on the right the next month in order Dec 2020

See comparison here
https://www.loom.com/share/2df7390a9e5f41ef93b3230b7e9fd9a6

you can compare it with the react version where it works correct
https://ourcwt--run.stackblitz.io/

What is expected?

have the months always appear in the correct order with no gaps.

What is actually happening?

the calendar selection month order doesn't make sense if the selection is more than two months

Environment Info
ng-zorro-antd 10.2.0
Browser chrome

please compare to react version and see the behavior is different
@wenqi73 wenqi73 added this to the v11.0.0 milestone Dec 7, 2020
wenqi73 added a commit to wenqi73/ng-zorro-antd that referenced this issue Jan 12, 2021
@wenqi73
fix(module:date-picker): start and end month displays unreasonable
39d9ef1 
fix(module:date-picker,timepicker): trackBy function

close NG-ZORRO#6308
close NG-ZORRO#6142
@wenqi73 wenqi73 mentioned this issue Jan 12, 2021
Merged
3 tasks
wenqi73 added a commit to wenqi73/ng-zorro-antd that referenced this issue Jan 12, 2021
@wenqi73
fix(module:date-picker): start and end month displays unreasonable
f546cb7 
fix(module:date-picker,timepicker): trackBy function

close NG-ZORRO#6308
close NG-ZORRO#6142
close NG-ZORRO#5992
wenqi73 added a commit to wenqi73/ng-zorro-antd that referenced this issue Jan 13, 2021
@wenqi73
fix(module:date-picker): start and end month displays unreasonable
86f6731 
fix(module:date-picker,timepicker): trackBy function

close NG-ZORRO#6308
close NG-ZORRO#6142
close NG-ZORRO#5992
hsuanxyz pushed a commit that referenced this issue Jan 18, 2021
@wenqi73
fix(module:date-picker): start and end month displays unreasonable (#…
7f47698 
…6339)

fix(module:date-picker,timepicker): trackBy function

close #6308
close #6142
close #5992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wenqi73 wenqi73

Labels
Component: DatePicker
Projects
None yet
Milestone
v11.0.0
Development

Successfully merging a pull request may close this issue.

fix(module:date-picker): start and end month displays unreasonable wenqi73/ng-zorro-antd
2 participants
@wenqi73 @idan-codefresh