Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nzAutoGenerate on breadcrumbs fails with empty string paths #5615

Closed
patricknazar opened this issue Jul 26, 2020 · 1 comment · Fixed by #5670
Closed

nzAutoGenerate on breadcrumbs fails with empty string paths #5615

patricknazar opened this issue Jul 26, 2020 · 1 comment · Fixed by #5670
Assignees

Comments

@patricknazar
Copy link

Reproduction link

https://stackblitz.com/edit/ng-zorro-antd-auto-breadcrumbs

Steps to reproduce

Hover over the breadcrumb link, the link has double slashes // in it because of the way this code in breadcrumb component works.

What is expected?

It should class multiple empty paths as just one path. Because of this, the links simply are wrong and don't work i.e. https://child instead of https://ng-zorro-antd-auto-breadcrumbs.stackblitz.io/child

What is actually happening?

It's joining empty paths with / and so if we have multiple we end up with // or more depending on how many levels deep we have

Environment Info
ng-zorro-antd 9.3.0
Browser Chrome
@patricknazar
Copy link
Author

Yeah ok so this is a duplicate of #5613 I did see this one but I thought it was different. I'll let someone else close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants