Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal prevents elements outside from being focused #5591

Closed
rppig42 opened this issue Jul 22, 2020 · 3 comments
Closed

Modal prevents elements outside from being focused #5591

rppig42 opened this issue Jul 22, 2020 · 3 comments

Comments

@rppig42
Copy link
Contributor

rppig42 commented Jul 22, 2020

Reproduction link

https://stackblitz.com/edit/angular-bc7gq8?file=src%2Fapp%2Fapp.component.ts

Steps to reproduce

  1. click button to open zorro modal
  2. click button to open custom modal
  3. click input within the custom modal

What is expected?

input can get focused

What is actually happening?

input will never get focused

Environment Info
ng-zorro-antd 9.3.0
Browser Chrome latest

the behavior works as expected before 9.1.2

@rppig42
Copy link
Contributor Author

rppig42 commented Jul 22, 2020

This problem happens in both Modal and Drawer component.

In the release of zorro 9.1.2, the version of angular/cdk bumps to 9.2.4.

But it doesn't seem to be an angular CDK issue as it works well in Angular material.

https://stackblitz.com/edit/angular-wcny5s?file=src%2Fapp%2Fdialog-content-example.ts

@rppig42
Copy link
Contributor Author

rppig42 commented Jul 22, 2020

Turns out that the change from FocusTrapFactory to ConfigurableFocusTrapFactory leads to this bug.

Can we change back to FocusTrapFactory for now?

As we can see from https://github.com/angular/components/blob/ba441d44fb8fa725cd2fd9ac2f6574cefc4f4307/src/material/dialog/dialog-container.ts#L32, Angular Material is still using the deprecated FocusTrapFactory in V10

@zorro-bot
Copy link

zorro-bot bot commented Jul 22, 2020

Hello @rppig42. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please fill the Pull Request Template here, provide documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @rppig42, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请务必填写 Pull Request 内的预设模板,提供改动所需相应的测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!
giphy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants