Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modal closing times error after the host view destroyed #5259

Closed
llkui opened this issue May 12, 2020 · 1 comment
Closed

modal closing times error after the host view destroyed #5259

llkui opened this issue May 12, 2020 · 1 comment
Assignees
@hsuanxyz
Labels
Component: Modal

Comments

@llkui
Copy link

llkui commented May 12, 2020

Reproduction link

https://stackblitz.com/edit/angular-wgbxwe

Steps to reproduce

1、open modal
2、click go to page2
3、console error: Uncaught (in promise): TypeError: Cannot read property 'nativeNode' of null
TypeError: Cannot read property 'nativeNode' of null

What is expected?

1、modal close
2、page jump correctly

What is actually happening?

1、page is not jump properly

Environment Info
ng-zorro-antd 9.1.1
Browser Google Chrome 80.0.3987.132
@wangxg6
Copy link

wangxg6 commented May 22, 2020

+1 遇到同样的问题，我这边直接关闭 modal 就会有这样的问题

hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue May 26, 2020
@hsuanxyz
fix(module:modal): some cases there is no changes detected
16ccd86 
close NG-ZORRO#5328, close NG-ZORRO#5287, close NG-ZORRO#5259
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Jun 16, 2020
@hsuanxyz
fix(module:modal): some cases there is no changes detected
63acf70 
close NG-ZORRO#5328, close NG-ZORRO#5287, close NG-ZORRO#5259
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@hsuanxyz
fix(module:modal): some cases there is no changes detected (NG-ZORRO#…
a0f39d2 
…5332)

* fix(module:modal): some cases there is no changes detected

close NG-ZORRO#5328, close NG-ZORRO#5287, close NG-ZORRO#5259

* docs(module:modal): update the API docs

close NG-ZORRO#3743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsuanxyz hsuanxyz

Labels
Component: Modal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@llkui @wangxg6 @hsuanxyz