Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NzModalService options (nzClosable, nzMaskClosable) not working as expected #4344

Closed
sivaecekrr opened this issue Oct 24, 2019 · 2 comments
Closed

Comments

@sivaecekrr
Copy link

Reproduction link

https://stackblitz.com/edit/angular-asqech

Steps to reproduce

Configure NzModalService in a component and enable nzClosable, nzMaskClosable. Even the example present in the document site is not working.

What is expected?

Close icon on top right corner should be visible and when click area outside the modal, then the modal should close.

What is actually happening?

The options nzClosable, nzMaskClosable are not working

Environment Info
ng-zorro-antd 8.4.1
Browser Chrome 77
@hsuanxyz
Copy link
Member

@sivaecekrr Thanks for the feedback. nzClosable unavailable in the confirm box mode is by design, but the nzMaskClosable not working is a bug. We will fix it in the next version.

@sivaecekrr
Copy link
Author

@hsuanxyz I agree for nzModalService.confirm nzClosable is not available. But the same applicable for nzModalService.info also. Because info mode doesn't need any confirmation. Let me know your thoughts. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants