Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab switching. If there are sub-tabs in a single tab, the selected status of the sub-tabs is not underlined. #3999

Closed
ng-nest-moon opened this issue Aug 13, 2019 · 0 comments · Fixed by #6016
Closed

Tab switching. If there are sub-tabs in a single tab, the selected status of the sub-tabs is not underlined. #3999

ng-nest-moon opened this issue Aug 13, 2019 · 0 comments · Fixed by #6016
Assignees
@hsuanxyz
Labels
🐛 Bug Component: Tabs
Milestone
backlog

Comments

@ng-nest-moon
Copy link

Reproduction link

https://stackblitz.com/edit/angular-mbwrpo

Steps to reproduce

Switch to the second tab, which has no underline selected

What is expected?

Switch to the second tab. Subtabs are underlined

What is actually happening?

Switch to the second tab, which has no underline selected

Environment Info
ng-zorro-antd 8.1.2
Browser 版本 74.0.3729.169（正式版本） （32 位）

It may be that the display: none style is set, and the underlined element cannot get the width.
I looked at the source code. The tabs component is implemented in a way similar to the Angular Material tabs component. They also have similar problems that have not been solved.
@hsuanxyz hsuanxyz self-assigned this Oct 22, 2020
@hsuanxyz hsuanxyz added this to the backlog milestone Oct 22, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Nov 6, 2020
@hsuanxyz
fix(module:tabs): ink-bar does not render correctly in some cases
1c448fa 
close NG-ZORRO#6009, close NG-ZORRO#4802, close NG-ZORRO#3999
@hsuanxyz hsuanxyz mentioned this issue Nov 6, 2020
Merged
3 tasks
hsuanxyz added a commit that referenced this issue Nov 6, 2020
@hsuanxyz
fix(module:tabs): ink-bar does not render correctly in some cases (#6016
8af418b 
)

close #6009, close #4802, close #3999
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsuanxyz hsuanxyz

Labels
🐛 Bug Component: Tabs
Projects
None yet
Milestone
backlog
Development

Successfully merging a pull request may close this issue.

fix(module:tabs): ink-bar does not render correctly in some cases hsuanxyz/ng-zorro-antd
5 participants
@vthinkxie @hsuanxyz @wenqi73 @ng-nest-moon and others