Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nz-switch distory issue #3760

Closed
luke-emmental opened this issue Jul 10, 2019 · 1 comment · Fixed by #3784
Closed

nz-switch distory issue #3760

luke-emmental opened this issue Jul 10, 2019 · 1 comment · Fixed by #3784
Assignees
@vthinkxie
Labels
Component: Switch Need More Info

Comments

@luke-emmental
Copy link

Reproduction link

https://stackblitz.com/edit/ng-zorro-antd-start-dfawrw?file=package.json

Steps to reproduce

sometimes nz-switch occur error

What is expected?

normal active

What is actually happening?

app-error-handler.ts:49 TypeError: Cannot read property 'nativeElement' of undefined
    at NzSwitchComponent.push.../../node_modules/ng-zorro-antd/fesm5/ng-zorro-antd-switch.js.NzSwitchComponent.ngOnDestroy (ng-zorro-antd-switch.js:134)
    at callProviderLifecycles (core.js:22087)
    at callElementProvidersLifecycles (core.js:22055)
    at callLifecycleHooksChildrenFirst (core.js:22045)
    at destroyView (core.js:30062)
    at callViewAction (core.js:30188)
    at execComponentViewsAction (core.js:30110)
    at destroyView (core.js:30061)
    at callViewAction (core.js:30188)
    at execComponentViewsAction (core.js:30110)
Environment Info
ng-zorro-antd 8.0.2
Browser chrome, firefox, safari

I think change @ViewChild static is false => true
@wzhudev
Copy link
Member

wzhudev commented Jul 10, 2019

@luke-emmental There is no error in the console. Please describe in detail.

屏幕快照 2019-07-10 上午11 09 13

@vthinkxie vthinkxie mentioned this issue Jul 13, 2019
Merged
3 tasks
vthinkxie added a commit that referenced this issue Jul 13, 2019
@vthinkxie
fix(module:switch): fix switch ViewChild static (#3784)
f59d79f 
close #3760
lppedd pushed a commit to lppedd/ng-zorro-antd that referenced this issue Jul 15, 2019
@vthinkxie @lppedd
fix(module:switch): fix switch ViewChild static (NG-ZORRO#3784)
d92d23b 
close NG-ZORRO#3760
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@vthinkxie @Ricbet
fix(module:switch): fix switch ViewChild static (NG-ZORRO#3784)
6d9fdd5 
close NG-ZORRO#3760
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@vthinkxie
fix(module:switch): fix switch ViewChild static (NG-ZORRO#3784)
37f5ca9 
close NG-ZORRO#3760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vthinkxie vthinkxie

Labels
Component: Switch Need More Info
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(module:switch): fix switch ViewChild static
3 participants
@vthinkxie @wzhudev @luke-emmental