-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear item after selected, In Version 7.0.0-RC3, it works fine #3021
Comments
Hi @lkhuoch , are you sure that the codes work fine in 7.0.0-rc.3? |
Yes, it works in version 7.0.0-RC3.
I used it everyday with version 7.0.0-RC3.
When I update to version 7.0.0, it has problem with clearing the nz-select
when select same item after cleaning. You just solve it in version 7.0.1.
I can confirm that it is worked it in version 7.0.0-RC3.
Thanks,
…On Mon, Mar 4, 2019, 5:19 PM vthinkxie ***@***.***> wrote:
Hi @lkhuoch <https://github.com/lkhuoch> , are you sure that the codes
work fine in 7.0.0-rc.3?
https://stackblitz.com/edit/nz700-xn38t6?file=src%2Fapp%2Fapp.component.ts
here is the reprolink of 7.0.0-rc.3
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3021 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AfXcVhD_B_14t00s90bXynawDdBTv1Mdks5vTPMvgaJpZM4bb-RL>
.
|
Is it fixed yet?
Thanks,
…On Mon, Mar 4, 2019, 6:33 PM vthinkxie ***@***.***> wrote:
Closed #3021 <#3021>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3021 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AfXcVvLiZChuKdVAuDVRn1DREREVBIJVks5vTQSYgaJpZM4bb-RL>
.
|
hi @lkhuoch this.form.setControl('product', new FormControl()) plz check the link above |
Ok, tomorrow I send the link to you via this email directly.
Thank for your time.
…On Mon, Mar 4, 2019, 7:16 PM vthinkxie ***@***.***> wrote:
hi @lkhuoch <https://github.com/lkhuoch>
I checked from 0.7.1 version to 7.0.0-rc.3 version, all versions before
can not work
this.form.setControl('product', new FormControl())
plz check the link above
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3021 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AfXcVgI6WAzG8H6FQ0l44XMHcHIgx_ktks5vTQ6IgaJpZM4bb-RL>
.
|
Good morning,
I created link for you to test it.
https://stackblitz.com/edit/nz700-rc3?file=src%2Fapp%2Fapp.component.ts
The product is reset automatically after i selected product from product
list, please check.
Thank for your support
…On Mon, Mar 4, 2019 at 11:20 PM Khuoch Loeng ***@***.***> wrote:
Ok, tomorrow I send the link to you via this email directly.
Thank for your time.
On Mon, Mar 4, 2019, 7:16 PM vthinkxie ***@***.***> wrote:
> hi @lkhuoch <https://github.com/lkhuoch>
> I checked from 0.7.1 version to 7.0.0-rc.3 version, all versions before
> can not work
>
> this.form.setControl('product', new FormControl())
>
> plz check the link above
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#3021 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AfXcVgI6WAzG8H6FQ0l44XMHcHIgx_ktks5vTQ6IgaJpZM4bb-RL>
> .
>
|
@lkhuoch this.form.setControl('product', new FormControl()); would not work in 7.0.0-rc.3 in your repro link |
Hello,
I mean it does not reset whole "this.form", but it is reset only "product"
select list in the form.
when you select "product 1" from the "product" select list still show
"select product" and I get the result value "Product: 1".
Please, check again.
Thank you
…On Tue, Mar 5, 2019 at 9:40 AM vthinkxie ***@***.***> wrote:
@lkhuoch <https://github.com/lkhuoch>
plz check it again, reset form with the code below
this.form.setControl('product', new FormControl());
would not work in 7.0.0-rc.3 in your repro link
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3021 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AfXcVs4CWM51KrmLwSlJ47_4s96m3ajOks5vTdkJgaJpZM4bb-RL>
.
|
yes, It could never work in any before versions, including 7.0.0-rc.3 version there is no method to watch set event |
Now, let compare with these two version of 7.0.0-RC3 and 7.0.0.
Version 7.0.0-RC3:
https://stackblitz.com/edit/nz700-rc3
Version 7.0.0:
https://stackblitz.com/edit/nz700
In version 7.0.0-RC3, it is clear or reset "product" select list to "Select
Product" placeholder.
In version 7.0.0, it is NOT clear or reset "product" select list, if you
select "product 1", it shows "product 1" in select list.
Please, check again
…On Tue, Mar 5, 2019 at 10:25 AM vthinkxie ***@***.***> wrote:
yes, this.form.setControl('product', new FormControl());
is and was not worked in any before version.
not only in latest version.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3021 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AfXcVvKlInqrTDM7X0OkhneCDiliu-pRks5vTeO5gaJpZM4bb-RL>
.
|
Version 7.0.0-RC3: can not work as what you say. |
I am so sorry to confuse you.
Verison 7.0.0-RC3:
https://stackblitz.com/edit/nz700-rc3?file=src%2Fapp%2Fapp.component.html
Version 7.0.0:
https://stackblitz.com/edit/nz700?file=src%2Fapp%2Fapp.component.ts
Please take a look at "Product" select list after you select any product
from the list.
Version 7.0.0-RC3, it is clear or reset automatically.
Version 7.0.0, it is NOT clear or reset, it still shows the selected
product.
All codes are the same.
Please, check again.
I am so sorry to confuse you.
…On Tue, Mar 5, 2019 at 10:45 AM vthinkxie ***@***.***> wrote:
[image: kapture 2019-03-05 at 11 44 40]
<https://user-images.githubusercontent.com/1506722/53779694-1b4b0600-3f3c-11e9-98fa-388b179b76f1.gif>
Version 7.0.0-RC3:
https://stackblitz.com/edit/nz700-rc3
can not work as what you say.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3021 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AfXcVkWdC9dYY9c7ALQ7-EHGkP_1CgvLks5vTehqgaJpZM4bb-RL>
.
|
Ok, thank for your help.
…On Tue, Mar 5, 2019 at 11:29 AM vthinkxie ***@***.***> wrote:
Reopened #3021 <#3021>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3021 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AfXcVkolOPP6yhCPRjRQyB-RxeqtXoRWks5vTfKmgaJpZM4bb-RL>
.
|
Hi @lkhuoch |
Reproduction link
https://stackblitz.com/edit/nz700?file=src%2Fapp%2Fapp.component.ts
Steps to reproduce
Note: I want clear the select option after selected item, in version 7.0.0-RC3 it worked fine
What is expected?
I want it works like previous version.
What is actually happening?
It does not clear after selected from select list with same code in previous version 7.0.0-RC3 and version 7.0.0
The text was updated successfully, but these errors were encountered: